Skip to content

🔊 Troubleshoot events with abnormally long durations #3944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

🔊 Troubleshoot events with abnormally long durations #3944

wants to merge 3 commits into from

Conversation

@bcaudan
Copy link
Collaborator

@bcaudan bcaudan commented Nov 4, 2025 •
edited
Loading

Motivation

Some events with very long duration are being collected.
Add telemetry log to see how frequently events are collected after session expiration.

Changes

When attaching session context, send a log if the session should be expired from some time

Test instructions

let's see how it behaves on the different environments

Checklist

  • Tested locally
  • Tested on staging
  • Added unit tests for this change.
  • Added e2e/integration tests for this change.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Nov 4, 2025 •
edited
Loading

✅ Tests

🎉 All green!

❄️ No new flaky tests detected
🧪 All tests passed

🎯 Code Coverage
• Patch Coverage: 42.86%
• Total Coverage: 92.51% (-0.13%)

View detailed report

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4718603 | Docs | Datadog PR Page | Was this helpful? Give us feedback!

@bcaudan bcaudan force-pushed the bcaudan/telemetry-expired-session branch from 0afd75e to 09c516a Compare November 4, 2025 16:12
@cit-pr-commenter
Copy link

cit-pr-commenter bot commented Nov 4, 2025 •
edited
Loading

Bundles Sizes Evolution

📦 Bundle Name Base Size Local Size 𝚫 𝚫% Status
Rum 162.78 KiB 163.67 KiB +908 B +0.54% ✅
Rum Recorder 19.78 KiB 19.78 KiB 0 B 0.00% ✅
Rum Profiler 4.84 KiB 4.84 KiB 0 B 0.00% ✅
Logs 56.62 KiB 56.80 KiB +184 B +0.32% ✅
Flagging 944 B 944 B 0 B 0.00% ✅
Rum Slim 119.90 KiB 120.73 KiB +852 B +0.69% ✅
Worker 23.60 KiB 23.60 KiB 0 B 0.00% ✅
🚀 CPU Performance

Pending...

🧠 Memory Performance
Action Name Base Memory Consumption Local Memory Consumption 𝚫
RUM - add global context 25.73 KiB 24.90 KiB -849 B
RUM - add action 46.34 KiB 45.34 KiB -1023 B
RUM - add timing 25.03 KiB 25.06 KiB +36 B
RUM - add error 51.20 KiB 50.36 KiB -855 B
RUM - start/stop session replay recording 24.21 KiB 24.02 KiB -190 B
RUM - start view 421.93 KiB 428.07 KiB +6.14 KiB
Logs - log message 41.22 KiB 43.08 KiB +1.86 KiB

🔗 RealWorld

@bcaudan
Copy link
Collaborator Author

bcaudan commented Nov 4, 2025

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 4, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-04 16:21:10 UTC ℹ️ Start processing command /to-staging

2025-11-04 16:21:17 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 0s (p90)

Commit 09c516af25 will soon be integrated into staging-45.

2025-11-04 16:40:27 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 09c516af25 has been merged into staging-45 in merge commit 7c63fdb160.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-45

dd-mergequeue bot added a commit that referenced this pull request Nov 4, 2025
@dd-mergequeue @bcaudan
Integrate bcaudan/telemetry-expired-session (#3944) into staging-45
7c63fdb 
Integrated commit sha: 09c516a

Co-authored-by: bcaudan <[email protected]>
@dd-devflow dd-devflow bot added the staging-45 label Nov 4, 2025
@bcaudan bcaudan force-pushed the bcaudan/telemetry-expired-session branch from 2df1156 to 2413b85 Compare November 5, 2025 18:09
@bcaudan bcaudan changed the title 🔊 Add debug log on events sent after session expiration 🔊 Troubleshoot evnts with abnormally long durations Nov 5, 2025
@bcaudan bcaudan changed the title 🔊 Troubleshoot evnts with abnormally long durations 🔊 Troubleshoot events with abnormally long durations Nov 5, 2025
@bcaudan
Copy link
Collaborator Author

bcaudan commented Nov 6, 2025

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 6, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-06 08:18:30 UTC ℹ️ Start processing command /to-staging

2025-11-06 08:18:38 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 19m (p90)

Commit 2413b851c1 will soon be integrated into staging-45.

2025-11-06 08:31:28 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 2413b851c1 has been merged into staging-45 in merge commit a2d2ce0885.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-45

dd-mergequeue bot added a commit that referenced this pull request Nov 6, 2025
@dd-mergequeue @bcaudan
Integrate bcaudan/telemetry-expired-session (#3944) into staging-45
a2d2ce0 
Integrated commit sha: 2413b85

Co-authored-by: bcaudan <[email protected]>
@bcaudan bcaudan force-pushed the bcaudan/telemetry-expired-session branch 2 times, most recently from c3c1916 to 4718603 Compare November 6, 2025 15:21
@bcaudan
Copy link
Collaborator Author

bcaudan commented Nov 6, 2025

/to-staging

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Nov 6, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-11-06 15:22:04 UTC ℹ️ Start processing command /to-staging

2025-11-06 15:22:11 UTC ℹ️ Branch Integration: starting soon, merge expected in approximately 19m (p90)

Commit 4718603c79 will soon be integrated into staging-45.

2025-11-06 15:47:19 UTC ℹ️ Branch Integration: this commit was successfully integrated

Commit 4718603c79 has been merged into staging-45 in merge commit b866342c34.

Check out the triggered pipeline on Gitlab 🦊

If you need to revert this integration, you can use the following command: /code revert-integration -b staging-45

dd-mergequeue bot added a commit that referenced this pull request Nov 6, 2025
@dd-mergequeue @bcaudan
Integrate bcaudan/telemetry-expired-session (#3944) into staging-45
b866342 
Integrated commit sha: 4718603

Co-authored-by: bcaudan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

staging-45

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bcaudan